Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve multi-choice field order in registration emails #5032

Merged

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Aug 5, 2021

Closes #5020

The problem is that RegistrationData is juggled around in many
places and doesn't keep the order given by the RegistrationFormField.
This is a problem only when asked for friendly_data.

Since RegistrationData keeps a reference to the underlying form field,
we can restore the order when we get the friendly data.

@tomasr8 tomasr8 force-pushed the email-registration-multi-choice-order branch from 6ce3a89 to f2a6615 Compare August 5, 2021 13:15
@tomasr8 tomasr8 force-pushed the email-registration-multi-choice-order branch from f2a6615 to 654ca20 Compare August 10, 2021 13:02
@ThiefMaster ThiefMaster merged commit 643caa5 into indico:3.0.x Aug 10, 2021
@ThiefMaster ThiefMaster deleted the email-registration-multi-choice-order branch August 10, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants