Do not hardcode QR code version in tickets #5052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 17 is very dense and not easily scannable. By not specifying a version the library uses the lowest version that can be used to fit the data, which results in a much more scannable QR code (since it's using a bigger grid)
ThiefMaster
force-pushed
the
qr-version
branch
from
3f7c871 to
0137d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QR version 17 is very dense and not easily scannable. By not specifying a version the library uses the lowest version that can be used to fit the data, which results in a much more easily scannable QR code (since it's using a bigger grid).
In case someone is curious, https://www.nayuki.io/page/qr-code-generator-library works nicely to play around with the different versions to see how they look like.