Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom statuses/registration tags #5091

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Add support for custom statuses/registration tags #5091

merged 3 commits into from
Oct 4, 2021

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Sep 16, 2021 •
edited
Loading

Closes #4948

This is a work-in-progress PR which adds the ability to create registration tags which
can be used to mark and filter registrations. For a full description, see the linked issue.

  • New management page to define registration tags (view,add,edit,delete)
  • Assign and remove tags individually or in bulk
  • Add ability to filter registrations based on these tags
  • A better looking multiple select when assigning tags? Like the one from SUI
  • Find a suitable icon (swapped with badges, badges get id-badge)

The management area for defining these tags:

image
image
image

The registration list area where one can assign and filter by these tags:

Screenshot from 2021-09-20 17-07-29
image
image
image

The registration detail page

(don't mind the wrong icon)

tags

@tomasr8 tomasr8 force-pushed the custom-tags branch 7 times, most recently from 52dbeb2 to f118779 Compare September 23, 2021 09:11
ThiefMaster
ThiefMaster reviewed Sep 23, 2021
View reviewed changes
indico/modules/events/registration/client/js/components/RegistrationTagsEditableList.jsx Outdated Show resolved Hide resolved
indico/modules/events/registration/controllers/management/registration_tags.py Outdated Show resolved Hide resolved
indico/modules/events/registration/controllers/management/registration_tags.py Outdated Show resolved Hide resolved
indico/modules/events/registration/controllers/management/registration_tags.py Outdated Show resolved Hide resolved
indico/modules/events/registration/controllers/management/reglists.py Outdated Show resolved Hide resolved
indico/modules/events/registration/templates/management/_registration_details.html Outdated Show resolved Hide resolved
indico/modules/events/registration/templates/management/_reglist.html Outdated Show resolved Hide resolved
indico/modules/events/registration/blueprint.py Outdated Show resolved Hide resolved
indico/modules/events/registration/templates/management/registration_tag_edit.html Outdated Show resolved Hide resolved
indico/modules/events/registration/templates/management/registration_tags.html Outdated Show resolved Hide resolved
@tomasr8 tomasr8 force-pushed the custom-tags branch 2 times, most recently from c1a3c00 to 2fa10b4 Compare September 23, 2021 17:02
@tomasr8 tomasr8 changed the title Add basic support for custom statuses/registration tags Add support for custom statuses/registration tags Sep 24, 2021
@tomasr8 tomasr8 force-pushed the custom-tags branch 2 times, most recently from 9458dee to 140d281 Compare September 24, 2021 14:20
@tomasr8 tomasr8 marked this pull request as ready for review September 24, 2021 14:27
ThiefMaster
ThiefMaster reviewed Sep 27, 2021
View reviewed changes
indico/modules/events/client/js/util/list_generator.js Show resolved Hide resolved
indico/modules/events/registration/models/registrations.py Outdated Show resolved Hide resolved
indico/modules/events/registration/models/registrations.py Outdated Show resolved Hide resolved
indico/modules/events/registration/models/registrations.py Outdated Show resolved Hide resolved
indico/modules/events/registration/models/registrations.py Outdated Show resolved Hide resolved
indico/modules/events/registration/models/registrations.py Outdated Show resolved Hide resolved
indico/modules/events/registration/templates/management/_reglist.html Outdated Show resolved Hide resolved
indico/modules/events/registration/templates/management/_reglist.html Outdated Show resolved Hide resolved
indico/web/templates/forms/multiple_tag_select_widget.html Outdated Show resolved Hide resolved
indico/web/templates/forms/multiple_tag_select_widget.html Outdated Show resolved Hide resolved
@tomasr8 tomasr8 force-pushed the custom-tags branch 2 times, most recently from 1dda55f to 472151b Compare September 27, 2021 15:22
ThiefMaster
ThiefMaster reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alembic/model inconsistencies

indico/modules/events/registration/models/tags.py Outdated Show resolved Hide resolved
indico/migrations/versions/20210927_1027_b36825c7869e_add_registration_tags.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster added this to the v3.1 milestone Sep 30, 2021
@tomasr8 tomasr8 force-pushed the custom-tags branch 3 times, most recently from 9e2a1f8 to 7d552ec Compare September 30, 2021 10:10
@ThiefMaster ThiefMaster mentioned this pull request Oct 1, 2021
Merged
@tomasr8
Add basic support for registration tags
83e408a 
Includes a new management page where one can
view, add, edit and remove tags. A tag is comprised of
a name and color.
@tomasr8
Add ability to assign and filter by registration tags
d3c9685
@tomasr8 tomasr8 force-pushed the custom-tags branch 2 times, most recently from b516542 to 2e30e8e Compare October 1, 2021 13:38
@ThiefMaster ThiefMaster merged commit 8c924b6 into indico:master Oct 4, 2021
@ThiefMaster ThiefMaster deleted the custom-tags branch October 4, 2021 08:40
ThiefMaster pushed a commit that referenced this pull request Oct 4, 2021
@tomasr8 @ThiefMaster
Add support for custom registration tags (#5091)
f7364ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiefMaster ThiefMaster ThiefMaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Generic way to mark/filter registrations
2 participants
@tomasr8 @ThiefMaster