Modify gettext to look through plural translations #5105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5073
This is kind of a hacky solution so I'm open to suggestions..
Basically, the problem is that if there is a plural translation ,e.g.,
the only way to translate
Convener
toLider
is to usengettext(..., 1)
.gettext
ignoresthe plural translations when looking for a translation.
The solution is to use our own
gettext
with a fallback tongettext
if a translation is not found.I don't know if this 100% foolproof as there might be some languages where a normal translation
differs from its singular translation when used with numbers.