Merged
Conversation
Contributor
Author
|
May I get a review here? I've tested this PR on v3 |
Member
|
Looks fine, but I'd like to have a unit test for this. I think we have a test for the function itself, so adding a new case covering this might be enough. |
ade428d to
e879f60
Compare
Contributor
Author
|
Hello, Morning, I added a test case to cover this. But, it is a hardcoded string of length 255, let me know if you'd prefer something autogenerated. |
vasantvohra
commented
Oct 21, 2021
ThiefMaster
reviewed
Oct 21, 2021
e879f60 to
324c094
Compare
ThiefMaster
reviewed
Oct 21, 2021
93cde8a to
b201c08
Compare
b201c08 to
fff0cd6
Compare
ThiefMaster
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users occasionally upload a file with a very lengthy name (>250) in the file field of the registration form; Mac and most OS allow up to 255 characters, but our servers return the error
[Errno 36] File name too long.Traceback: