Remove deleted registration forms from ACLs#5131
Merged
Merged
Conversation
ThiefMaster
reviewed
Oct 25, 2021
ThiefMaster
changed the title
ThiefMaster
force-pushed
the
Issue#5130
branch
from
58bdb0b to
26853b9
Compare
ThiefMaster
force-pushed
the
Issue#5130
branch
from
26853b9 to
9f658cc
Compare
ThiefMaster
approved these changes
Oct 26, 2021
ThiefMaster
added a commit
that referenced
this pull request
Jun 22, 2023
Before #5131 got merged, registration forms were not removed from ACLs when someone deleted the form. Cloning such an event would fail because the registration form is not in the mapping (as deleted forms are not cloned).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not sure about how to name this commit and PR, since it seems verbose to me, but I tend to talk verbosely, so feel free to change the name of the commit and PR however you feel it is cleanlier.