Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rendering of invites on Outlook #5178

Merged
merged 1 commit into from Nov 29, 2021

Conversation

pferreir
Copy link
Member

While clients such as Thunderbird can understand the ICS files we are attaching to our invites and ask the user whether they'd like to add them to their calendars:

image

... this doesn't seem to be the case with Outlook, which requires some additional metadata to do so. This PR solves that by providing the method=REQUEST field which is missing for that to happen.

Example:

image
image

Also added some gratuitous type information, since you can always count on me to type-annotate Python code.

indico/modules/events/ical.py Outdated Show resolved Hide resolved
indico/modules/events/ical.py Show resolved Hide resolved
indico/modules/events/reminders/models/reminders.py Outdated Show resolved Hide resolved
@ThiefMaster
Copy link
Member

I think this would be something nice for 3.1.x :) (and deserves a changelog entry IMHO)

indico/modules/events/ical.py Outdated Show resolved Hide resolved
indico/modules/events/ical.py Outdated Show resolved Hide resolved
@pferreir pferreir force-pushed the add-outlook-invite-rendering branch 2 times, most recently from 49715af to fdfc5f8 Compare November 26, 2021 16:10
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rebase to 3.1.x though

@pferreir pferreir changed the base branch from master to 3.1.x November 29, 2021 14:00
@pferreir
Copy link
Member Author

Rebased.

@ThiefMaster ThiefMaster merged commit b8cd3fa into indico:3.1.x Nov 29, 2021
@ThiefMaster ThiefMaster deleted the add-outlook-invite-rendering branch November 29, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants