Implement rendering of invites on Outlook #5178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Nov 26, 2021
Member
|
I think this would be something nice for 3.1.x :) (and deserves a changelog entry IMHO) |
pferreir
force-pushed
the
add-outlook-invite-rendering
branch
from
5a010de to
b1fb6bb
Compare
ThiefMaster
reviewed
Nov 26, 2021
pferreir
force-pushed
the
add-outlook-invite-rendering
branch
2 times, most recently
from
49715af to
fdfc5f8
Compare
ThiefMaster
approved these changes
Nov 26, 2021
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
Let's rebase to 3.1.x though
pferreir
force-pushed
the
add-outlook-invite-rendering
branch
from
fdfc5f8 to
b8cd3fa
Compare
Member
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While clients such as Thunderbird can understand the ICS files we are attaching to our invites and ask the user whether they'd like to add them to their calendars:
... this doesn't seem to be the case with Outlook, which requires some additional metadata to do so. This PR solves that by providing the
method=REQUESTfield which is missing for that to happen.Example:
Also added some gratuitous type information, since you can always count on me to type-annotate Python code.