Fix category search displaying deleted categories #5203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is fixing a bug a changelog entry would be nice. "Do not show deleted categories in category picker search" or something like that. |
duartegalvao
force-pushed
the
search-deleted-categories
branch
3 times, most recently
from
60e6db7 to
7c32c16
Compare
ThiefMaster
reviewed
Dec 20, 2021
duartegalvao
force-pushed
the
search-deleted-categories
branch
from
7c32c16 to
2465a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5197
This PR includes the fix for the described issue, as well as a unit test for category searches.