Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for abstract cloning #5217

Merged
merged 8 commits into from
Jan 28, 2022
Merged

Conversation

plourenco
Copy link
Member

Adds support for a new cloning handle, that generates a new abstract form with pre-filled information.
Also ensures a single row is selected/cloned at a time.

For the sake of simplicity, I'm re-using the existing RHCreateAbstract.

@plourenco plourenco marked this pull request as ready for review January 19, 2022 19:52
@plourenco plourenco self-assigned this Jan 19, 2022
@plourenco plourenco force-pushed the abstract-clone branch 2 times, most recently from eae6188 to 6037a2b Compare January 20, 2022 16:14
@ThiefMaster ThiefMaster added this to the v3.1 milestone Jan 20, 2022
@ThiefMaster
Copy link
Member

ThiefMaster commented Jan 20, 2022

Besides these small suggestions it seems fine! Could you add a changelog entry though?

CHANGES.rst Outdated Show resolved Hide resolved
indico/modules/events/client/js/util/list_generator.js Outdated Show resolved Hide resolved
plourenco and others added 7 commits January 27, 2022 13:02
Create a dedicated cloning handle
Even though each link loses the abstract relation when serialized
by the form, cloning ensures correctness in the intermediate step.
Fix an issue causing an abstract to be cloned by any event
Co-authored-by: Adrian <adrian@planetcoding.net>
CHANGES.rst Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster enabled auto-merge (squash) January 28, 2022 15:27
@ThiefMaster ThiefMaster merged commit 04b1063 into indico:3.1.x Jan 28, 2022
@ThiefMaster ThiefMaster deleted the abstract-clone branch January 28, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

2 participants