Add support for abstract cloning#5217
Merged
ThiefMaster merged 8 commits intoindico:3.1.xfrom Jan 28, 2022
Merged
Conversation
plourenco
commented
Jan 19, 2022
ThiefMaster
reviewed
Jan 20, 2022
plourenco
force-pushed
the
abstract-clone
branch
from
830b471 to
67705f4
Compare
ThiefMaster
reviewed
Jan 20, 2022
ThiefMaster
reviewed
Jan 20, 2022
indico/modules/events/abstracts/templates/management/abstract_list.html
Outdated
Show resolved
Hide resolved
plourenco
force-pushed
the
abstract-clone
branch
2 times, most recently
from
eae6188 to
6037a2b
Compare
ThiefMaster
reviewed
Jan 20, 2022
indico/modules/events/abstracts/templates/management/abstract_list.html
Outdated
Show resolved
Hide resolved
Member
|
Besides these small suggestions it seems fine! Could you add a changelog entry though? |
ThiefMaster
reviewed
Jan 27, 2022
Create a dedicated cloning handle
Even though each link loses the abstract relation when serialized by the form, cloning ensures correctness in the intermediate step.
Fix an issue causing an abstract to be cloned by any event
Co-authored-by: Adrian <adrian@planetcoding.net>
plourenco
force-pushed
the
abstract-clone
branch
from
55e7e17 to
4f42215
Compare
ThiefMaster
reviewed
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new cloning handle, that generates a new abstract form with pre-filled information.
Also ensures a single row is selected/cloned at a time.
For the sake of simplicity, I'm re-using the existing
RHCreateAbstract.