Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard wrapping to map URL in event settings #5275

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

javfg
Copy link
Contributor

@javfg javfg commented Mar 8, 2022

This PR fixes very long map URLs from breaking out of the settings box in event management.

Before:

image

After:

image

@javfg javfg marked this pull request as ready for review March 8, 2022 14:29
@ThiefMaster
Copy link
Member

I think think one is a good 3.1.x candidate as well. Generally we can put bugfixes for things that already occur in production into that branch; no need to delay them until the next release. Especially if they are very simple and unlikely to cause any n egative side effects.

@javfg javfg force-pushed the settings-mapurl-wrap branch 3 times, most recently from 1cba1c6 to cdcf122 Compare March 9, 2022 10:21
@ThiefMaster ThiefMaster changed the base branch from master to 3.1.x March 9, 2022 10:31
@ThiefMaster ThiefMaster merged commit a546d39 into indico:3.1.x Mar 9, 2022
@ThiefMaster ThiefMaster deleted the settings-mapurl-wrap branch March 9, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants