Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading revisions when an editor hasn't been assigned #5289

Merged
merged 16 commits into from
Apr 20, 2022

Conversation

plourenco
Copy link
Member

@plourenco plourenco commented Mar 15, 2022

Once an editable has been submitted, it is currently impossible to upload a new version of it. The improvement would allow a new revision to be made at any time (but disallowed when an editor has been assigned - to prevent him from seeing an old version).

@plourenco plourenco force-pushed the upload-revision branch 2 times, most recently from 674f5e4 to b6abfd3 Compare March 21, 2022 14:57
@plourenco plourenco marked this pull request as ready for review March 22, 2022 14:12
@plourenco plourenco changed the base branch from master to 3.1.x March 29, 2022 12:08
@plourenco plourenco force-pushed the upload-revision branch 2 times, most recently from b7fdb76 to 0b0d0cc Compare March 30, 2022 13:49
@plourenco plourenco marked this pull request as draft April 1, 2022 13:26
@plourenco plourenco marked this pull request as ready for review April 5, 2022 14:06
@plourenco plourenco force-pushed the upload-revision branch 2 times, most recently from 55409e9 to 6d9aac8 Compare April 5, 2022 14:16
As PaperFile and File are two different models, having a single
param for both would cause file conflicts
Due to the nature of FileManager, the attributes that identify a file
depend on a `id` field which causes conflicts if we rely on two
different models (`File` and `PaperFile`).

For that reason, considering papers are an exceptional case, I renamed
the attribute within this domain in order for the upload request to
succeed.
@ThiefMaster ThiefMaster added this to the v3.1 milestone Apr 20, 2022
@ThiefMaster ThiefMaster merged commit 83ad6fd into indico:3.1.x Apr 20, 2022
@ThiefMaster ThiefMaster deleted the upload-revision branch April 20, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

2 participants