Allow uploading revisions when an editor hasn't been assigned#5289
Merged
ThiefMaster merged 16 commits intoindico:3.1.xfrom Apr 20, 2022
Merged
Allow uploading revisions when an editor hasn't been assigned#5289ThiefMaster merged 16 commits intoindico:3.1.xfrom
ThiefMaster merged 16 commits intoindico:3.1.xfrom
Conversation
plourenco
force-pushed
the
upload-revision
branch
2 times, most recently
from
674f5e4 to
b6abfd3
Compare
plourenco
force-pushed
the
upload-revision
branch
from
b6abfd3 to
b152df9
Compare
ThiefMaster
reviewed
Mar 22, 2022
plourenco
force-pushed
the
upload-revision
branch
from
6e6a079 to
1553d53
Compare
plourenco
force-pushed
the
upload-revision
branch
2 times, most recently
from
b7fdb76 to
0b0d0cc
Compare
ThiefMaster
reviewed
Mar 31, 2022
plourenco
force-pushed
the
upload-revision
branch
from
b00ed61 to
ab05c96
Compare
plourenco
force-pushed
the
upload-revision
branch
2 times, most recently
from
55409e9 to
6d9aac8
Compare
ThiefMaster
reviewed
Apr 6, 2022
plourenco
force-pushed
the
upload-revision
branch
from
918fb97 to
4bef86e
Compare
ThiefMaster
approved these changes
Apr 8, 2022
plourenco
force-pushed
the
upload-revision
branch
from
c859977 to
4be3495
Compare
As PaperFile and File are two different models, having a single param for both would cause file conflicts
Due to the nature of FileManager, the attributes that identify a file depend on a `id` field which causes conflicts if we rely on two different models (`File` and `PaperFile`). For that reason, considering papers are an exceptional case, I renamed the attribute within this domain in order for the upload request to succeed.
plourenco
force-pushed
the
upload-revision
branch
from
4be3495 to
8c96563
Compare
ThiefMaster
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once an editable has been submitted, it is currently impossible to upload a new version of it. The improvement would allow a new revision to be made at any time (but disallowed when an editor has been assigned - to prevent him from seeing an old version).