Add alarm support to exported iCal. #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerilousApricot
force-pushed
the
feature/add-ical-alerts
branch
from
a2b8c58
to
7cb757b
Compare
ThiefMaster
reviewed
Apr 12, 2022
PerilousApricot
force-pushed
the
feature/add-ical-alerts
branch
4 times, most recently
from
c9ee8b8
to
8ad3818
Compare
|
@ThiefMaster I've done your suggestion and split the preference into two parts, it is commit cf265cf. I don't know how to do the hidden field thing you talk about, though, so it's not yet complete |
ThiefMaster
reviewed
Apr 12, 2022
|
thanks! i added the HiddenUnless in my review comment; this should be all that's needed - the rest is magic ✨ that happens automatically when this validator is used |
|
OK @ThiefMaster! I think I have this fully implemented in 31386b8 |
ThiefMaster
reviewed
Apr 12, 2022
|
Thanks, looks good! I'll test it tomorrow - already way too late anyway :D |
|
@ThiefMaster thanks! have a good evening :) |
Many (all?) calendar clients do not support adding reminders ("alerts"
in iCal parlance) to external calendars syncrhonized via URL. Add a
per-user preference to attach reminders to any events exported to iCal.
Tested on local dev install both as a logged-in and anonymous user, both
with and without a reminder preference. This produced an iCal that Apple
Calendars properly recognized the reminders:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//CERN//INDICO//EN
BEGIN:VEVENT
SUMMARY:testEvent title
DTSTART;VALUE=DATE-TIME:20220425T150000Z
DTEND;VALUE=DATE-TIME:20220425T170000Z
DTSTAMP;VALUE=DATE-TIME:20220412T151800Z
UID:indico-event-8@localhost
DESCRIPTION:testEvent Description\n\nhttp://localhost:8000/event/8/
URL:http://localhost:8000/event/8/
BEGIN:VALARM
ACTION:AUDIO
DESCRIPTION:testEvent Description\n\nhttp://localhost:8000/event/8/
PRODID:-//CERN//INDICO//EN
SUMMARY:testEvent title
TRIGGER:-PT5M
END:VALARM
END:VEVENT
END:VCALENDAR
Fixed indico#5318
Instead of one field having two meaning, split the preferences into two, where one preference enables the iCal alert functionality, and the other chooses the timeout
ThiefMaster
force-pushed
the
feature/add-ical-alerts
branch
from
4a3bf9d
to
65eb670
Compare
ThiefMaster
approved these changes
Apr 20, 2022
|
Thanks a lot!--
It's dark in this basement.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many (all?) calendar clients do not support adding reminders ("alerts"
in iCal parlance) to external calendars syncrhonized via URL. Add a
per-user preference to attach reminders to any events exported to iCal.
Tested on local dev install both as a logged-in and anonymous user, both
with and without a reminder preference. This produced an iCal that Apple
Calendars properly recognized the reminders:
closes #5318