Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade text editor to ckeditor5 #5345

Merged
merged 19 commits into from
Jul 14, 2022
Merged

Conversation

plourenco
Copy link
Member

@plourenco plourenco commented May 16, 2022

  • Support markdown and/or convert all output to HTML
  • Move width/height properties to CSS
  • Provide a simple version
  • Attribute changes (e.g. font colors) do not modify disabled_until_change

@plourenco plourenco marked this pull request as ready for review May 18, 2022 09:17
@plourenco plourenco force-pushed the ckeditor5 branch 2 times, most recently from dcc9b5e to 4480839 Compare June 13, 2022 10:24
@ThiefMaster
Copy link
Member

Can't we get the editor to use two rows of buttons instead of the ... menu? Not sure if users will realize some options they may have used before are now in there...

@plourenco
Copy link
Member Author

Can't we get the editor to use two rows of buttons instead of the ... menu? Not sure if users will realize some options they may have used before are now in there...

Well, we can, but it looks a bit more cluttered.

@ThiefMaster
Copy link
Member

Would be nice to see screenshots of the two options for a direct comparison ;)

@plourenco
Copy link
Member Author

Would be nice to see screenshots of the two options for a direct comparison ;)

It depends on the breakpoint (where the items break into another line), and also the editor width. But it will end up something like this:

Normal Collapsed
Captura de ecrã 2022-06-13, às 16 00 51 Captura de ecrã 2022-06-13, às 16 01 08
Captura de ecrã 2022-06-13, às 16 01 40 Captura de ecrã 2022-06-13, às 16 01 27

@ThiefMaster
Copy link
Member

OK, if there are half-filled toolbars it certainly looks weird...

@ThiefMaster ThiefMaster merged commit f1872cc into indico:master Jul 14, 2022
@ThiefMaster ThiefMaster deleted the ckeditor5 branch July 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants