Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for mandatory Affiliation and Comment fields #5389

Merged
merged 9 commits into from
Jul 22, 2022

Conversation

elsbethe
Copy link
Contributor

@elsbethe elsbethe commented Jun 24, 2022

Add a setting for making the 'Affiliation' and 'Comment' field mandatory when creating a new account. When setting is active, the corresponding field is mandatory in the sign up form.

closes #4819

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also add server-side validation to make sure the mandatory fields are not empty.

indico/modules/auth/client/js/signup.jsx Outdated Show resolved Hide resolved
indico/modules/auth/client/js/signup.jsx Outdated Show resolved Hide resolved
indico/modules/users/forms.py Outdated Show resolved Hide resolved
@elsbethe
Copy link
Contributor Author

Thanks for your quick feedback! I added the server-side validation and processed your feedback.

indico/modules/users/forms.py Outdated Show resolved Hide resolved
indico/modules/auth/controllers.py Outdated Show resolved Hide resolved
indico/modules/auth/controllers.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster force-pushed the mandatory-fields-account-form branch from 8eb45fe to 76e1db4 Compare July 22, 2022 09:59
@ThiefMaster ThiefMaster added this to the v3.2 milestone Jul 22, 2022
Since we check for not_empty it's no longer needed to remove it.
Non-local providers can use moderation as well, but that wasn't checked
so the options for madatory fields were not shown
@ThiefMaster ThiefMaster enabled auto-merge (squash) July 22, 2022 10:35
@ThiefMaster ThiefMaster merged commit 844fccb into indico:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandatory fields "Affiliation" and "Comment" in the account request form
2 participants