Add UI to manage series of events #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leats
force-pushed
the
event-series
branch
3 times, most recently
from
e169452
to
0d6a4ab
Compare
ThiefMaster
reviewed
Aug 5, 2022
ThiefMaster
reviewed
Aug 5, 2022
indico/modules/events/management/client/js/SeriesManagement.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/management/client/js/SeriesManagement.jsx
Outdated
Show resolved
Hide resolved
Leats
force-pushed
the
event-series
branch
4 times, most recently
from
a28226a
to
f147f34
Compare
ThiefMaster
reviewed
Aug 11, 2022
- show searching indicator while searching - remove min length before showing results (`indico#1` etc is otherwise broken) - never search for `#` - deduplicate disabled logic - fix removing and re-adding event from current series
Otherwise people may wonder why an event doesn't show up, and it's also needed in case someone clicks the X on the current event in a series to remove it and then wants to add it back.
- keep search term so clicking it again will show the results again (avoids having to search again and again when a single resultset contains multiple events the use wants to add) - improve flexbox styling and add scroll if it gets too big - remove some unused code (Form/keyword)
ThiefMaster
approved these changes
Aug 12, 2022
Otherwise the leading zero triggers legacy event id handling logic which will cause an error if there's no such legacy event id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4048.
Adds the ability to manage/create series when editing an event.
Preview: