Insert new categories in the right place if the categories are already sorted#5455
Merged
Conversation
ThiefMaster
reviewed
Aug 17, 2022
tomasr8
force-pushed
the
sort-new-categories
branch
2 times, most recently
from
7e1ffb0 to
5e8f63f
Compare
tomasr8
force-pushed
the
sort-new-categories
branch
from
5e8f63f to
b4d035f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New categories are currently always appended to the end, even if the list has been sorted.
This change checks whether the categories are sorted (either ascending or descending) and inserts
the new category in the correct place.