Add email checker for person links #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tomasr8
commented
Aug 29, 2022
•
tomasr8
commented
- Email is not mandatory, but if used it is checked like in registrations
- Prevents adding two people with the same email
- Checks for secondary emails and prevents adding the same user with a different email
- Warns if the person already has an Indico account
- Warns if the person is already linked to the event - in this case if there is already a person link, it will be updated with the new data and the old link will be deleted. This takes care of the issue where there are existing person links linked to deleted objects preventing users from changing emails when updating person links.
ThiefMaster
reviewed
Aug 29, 2022
tomasr8
force-pushed
the
person-link-modal
branch
4 times, most recently
from
6522295 to
b21b86e
Compare
ThiefMaster
reviewed
Sep 16, 2022
tomasr8
force-pushed
the
person-link-modal
branch
from
b21b86e to
03b99d6
Compare
tomasr8
force-pushed
the
person-link-modal
branch
2 times, most recently
from
ff1fe1f to
f92c5fa
Compare
ThiefMaster
force-pushed
the
person-link-modal
branch
2 times, most recently
from
f10d6cf to
d0e8cb1
Compare
ThiefMaster
reviewed
Nov 28, 2022
tomasr8
force-pushed
the
person-link-modal
branch
3 times, most recently
from
7971cf4 to
e06b2d2
Compare
tomasr8
force-pushed
the
person-link-modal
branch
2 times, most recently
from
b6b1dd3 to
8503d27
Compare
ThiefMaster
reviewed
Dec 1, 2022
tomasr8
force-pushed
the
person-link-modal
branch
from
607112f to
0336140
Compare
ThiefMaster
reviewed
Dec 2, 2022
tomasr8
force-pushed
the
person-link-modal
branch
5 times, most recently
from
c6c1167 to
898e695
Compare
ThiefMaster
force-pushed
the
person-link-modal
branch
from
898e695 to
568d91f
Compare
tomasr8
force-pushed
the
person-link-modal
branch
from
568d91f to
53c047e
Compare
Allows changing to an email which is already used by another event person. This will cause the new person link to be updated and the old person link will be deleted. Also adds basic email validation similar to that in registration.
ThiefMaster
force-pushed
the
person-link-modal
branch
from
53c047e to
a5dc359
Compare
ThiefMaster
force-pushed
the
person-link-modal
branch
from
2bf1b56 to
4d8ff71
Compare
ThiefMaster
approved these changes
Jan 20, 2023
ThiefMaster
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.