Fix incorrect width & height calculation in badges #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Aug 30, 2022
tomasr8
force-pushed
the
badges-margin-fix
branch
from
184391c to
15edf1e
Compare
When calculating how many columns of badges fit on a page, the column margin between badges is counted for each badge while it should only count (N-1)-times.
tomasr8
force-pushed
the
badges-margin-fix
branch
from
15edf1e to
ee4193e
Compare
tomasr8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating how many columns of badges fit on a page,
the column margin between badges is counted for each badge while it should only count (N-1)-times.