Parse escaped quotes (") in ckeditor output correctly.#5487
Merged
Conversation
Member
|
a unit test for this would be nice |
Member
|
and maybe also a bugfix entry in the 3.2.1 changelog? |
ThiefMaster
reviewed
Sep 6, 2022
ThiefMaster
reviewed
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like ckeditor4 (and maybe 5) escapes quotes in font family names.
The css sanitizer doesn't like this and throws the quotes out which in turn breaks the styles altogether.
Related ckeditor issue: ckeditor/ckeditor4#2750