Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to disable entering persons manually #5499

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

duartegalvao
Copy link
Member

@duartegalvao duartegalvao commented Sep 15, 2022

This PR adds a setting to disable the option of submitters writing in persons manually in the PersonLinkField.

The setting is located in the Participant Roles page in the management area:
image
image

Disabled:
image

Enabled:
image

Progress:

  • Add setting in the management area
  • Hide the "enter manually" button when the setting is disabled
  • Add server side check

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think right now there's no "enforcement" of this, it's just disabling the option in the UI?

indico/modules/events/persons/__init__.py Outdated Show resolved Hide resolved
@duartegalvao
Copy link
Member Author

I think right now there's no "enforcement" of this, it's just disabling the option in the UI?

Right now yes, it's the next item on the progress list

@duartegalvao duartegalvao force-pushed the disable-enter-manually branch 2 times, most recently from ef6e6b1 to 88a204a Compare September 19, 2022 14:46
@duartegalvao duartegalvao marked this pull request as ready for review September 19, 2022 14:47
@duartegalvao duartegalvao changed the title Add a setting to disable entering authors manually Add a setting to disable entering persons manually Sep 19, 2022
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we also need to disallow "edit" after adding someone via the search

indico/modules/events/persons/forms.py Outdated Show resolved Hide resolved
indico/modules/events/persons/forms.py Outdated Show resolved Hide resolved
indico/modules/events/persons/controllers.py Outdated Show resolved Hide resolved
indico/modules/events/persons/forms.py Outdated Show resolved Hide resolved
data-href="{{ url_for('.manage_person_lists', event) }}"
data-qtip-position="right"
data-ajax-dialog>
{% trans %}Person lists{% endtrans %}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this title. Can't think of a better one though....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like "submitters' permissions"?

@ThiefMaster ThiefMaster merged commit cff34e9 into indico:master Sep 30, 2022
@duartegalvao duartegalvao deleted the disable-enter-manually branch September 30, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

2 participants