Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow taking minutes in markdown #5500

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Conversation

Leats
Copy link
Contributor

@Leats Leats commented Sep 15, 2022

Depends on #5491.
Closes #3386.
Users can choose in their preferences to use a markdown editor instead of the html editor. For editing notes the editor will always be the one with which the note was originally created.

Uses the React Markdown Editor Lite, which was suggested by @pferreir.

Screenshot of the Markdown Editor Modal

@pferreir
Copy link
Member

Game changer!

@Leats Leats force-pushed the markdown-minutes branch 3 times, most recently from 2e63e72 to b28cc19 Compare September 20, 2022 14:54
@Leats Leats force-pushed the markdown-minutes branch 3 times, most recently from 2aba099 to fc7f979 Compare September 26, 2022 12:04
@Leats Leats force-pushed the markdown-minutes branch 4 times, most recently from 4fe920e to 86402f3 Compare September 26, 2022 16:07
@Leats Leats force-pushed the markdown-minutes branch 5 times, most recently from 3ea8758 to 1d23451 Compare October 2, 2022 12:51
@Leats Leats force-pushed the markdown-minutes branch from 1d23451 to 986b364 Compare October 2, 2022 13:00
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final comments :)

indico/modules/core/controllers.py Outdated Show resolved Hide resolved
indico/modules/core/controllers.py Outdated Show resolved Hide resolved
indico/modules/core/controllers.py Outdated Show resolved Hide resolved
indico/modules/users/controllers.py Outdated Show resolved Hide resolved
indico/web/client/js/react/components/MarkdownEditor.jsx Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster added this to the v3.2 milestone Oct 4, 2022
@ThiefMaster ThiefMaster enabled auto-merge (squash) October 4, 2022 10:05
@ThiefMaster ThiefMaster merged commit 719eb19 into indico:master Oct 4, 2022
@adavidzh
Copy link

adavidzh commented Oct 4, 2022

Thank you all for this improvement!

@ThiefMaster ThiefMaster deleted the markdown-minutes branch October 4, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take minutes in markdown
4 participants