-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow taking minutes in markdown #5500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leats
force-pushed
the
markdown-minutes
branch
from
September 16, 2022 09:38
3a1abbc
to
2071130
Compare
Game changer! |
Leats
force-pushed
the
markdown-minutes
branch
3 times, most recently
from
September 20, 2022 14:54
2e63e72
to
b28cc19
Compare
ThiefMaster
reviewed
Sep 21, 2022
Leats
force-pushed
the
markdown-minutes
branch
3 times, most recently
from
September 26, 2022 12:04
2aba099
to
fc7f979
Compare
ThiefMaster
reviewed
Sep 26, 2022
indico/web/client/js/react/components/MarkdownEditor.module.scss
Outdated
Show resolved
Hide resolved
Leats
force-pushed
the
markdown-minutes
branch
4 times, most recently
from
September 26, 2022 16:07
4fe920e
to
86402f3
Compare
Leats
force-pushed
the
markdown-minutes
branch
5 times, most recently
from
October 2, 2022 12:51
3ea8758
to
1d23451
Compare
Leats
force-pushed
the
markdown-minutes
branch
from
October 2, 2022 13:00
1d23451
to
986b364
Compare
ThiefMaster
reviewed
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final comments :)
ThiefMaster
approved these changes
Oct 4, 2022
Thank you all for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5491.
Closes #3386.
Users can choose in their preferences to use a markdown editor instead of the html editor. For editing notes the editor will always be the one with which the note was originally created.
Uses the React Markdown Editor Lite, which was suggested by @pferreir.