Fix "Submit Answer For" form submission#5574
Merged
Merged
Conversation
ThiefMaster
force-pushed
the
fix-agreements
branch
from
b4646dd to
c73ca34
Compare
ThiefMaster
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that made the "Submit" button always disabled in the "Submit Answer For" dialog for Agreements.
The bug was caused by the recent change of i-buttons from
<a>to<button>(#5545), which caused the custom script in this form to interpret the "Cancel" button as one of the inputs to check. The check always failed because the value of the button was interpreted asfalse.