Display all contributions in 'My contributions' #5575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Nov 21, 2022
indico/modules/events/contributions/templates/display/user_contribution_list.html
Outdated
Show resolved
Hide resolved
tomasr8
force-pushed
the
my-contributions
branch
3 times, most recently
from
6ce0b39 to
c783a94
Compare
ThiefMaster
reviewed
Nov 21, 2022
|
What do you think about hiding contributions in the "submitter" list if it's already listed anywhere else? |
tomasr8
force-pushed
the
my-contributions
branch
4 times, most recently
from
46669fc to
1c913bd
Compare
Instead of showing only contributions for which the user is a submitter, we show all contributions categorized by primary/secondary author & speaker.
ThiefMaster
force-pushed
the
my-contributions
branch
from
1c913bd to
f43f6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing only contributions for which the user is a submitter,
we show all contributions categorized by primary/secondary author, speaker or submitter.
Contributions in the
Submittersection are only shown if the user neither an author or a speaker.Not-so-obvious edge case: a user can have submission rights on a contribution w/o having a person link (= not added in the
Peoplefield in contribution settings) - these contributions are included.