Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings for a default and additional languages to an event #5607

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Add settings for a default and additional languages to an event #5607

merged 6 commits into from
Feb 2, 2023

Conversation

vasantvohra
Copy link
Contributor

@vasantvohra vasantvohra commented Dec 31, 2022 •
edited
Loading

closes

  1. Add an event setting for default and additional languages to the event settings page

Screenshot 2023-01-23 at 7 45 15 PM

Screenshot 2023-01-23 at 7 45 27 PM

  1. Add a user preferences that allows users to forcefully use their preferred language on the event display page

Screenshot 2023-01-23 at 7 45 53 PM

  1. On the event display page, users can change to other languages from the session bar, but only event-supported languages will be available and all other languages will be disabled.

Screenshot 2023-01-23 at 7 51 02 PM

  1. Additionally, when sending automated emails to registrants, the language selected will be based on the preferences of the user attached to the registration, if registration is without a user the event default is used.

  2. A unit test is added for the event's language selection behavior.

ThiefMaster
ThiefMaster reviewed Jan 8, 2023
View reviewed changes
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR, I just updated the headers so after a rebase these CI warnings will go away

indico/modules/events/models/events.py Outdated Show resolved Hide resolved
indico/modules/users/forms.py Outdated Show resolved Hide resolved
indico/modules/events/operations.py Outdated Show resolved Hide resolved
indico/modules/events/settings.py Outdated Show resolved Hide resolved
indico/modules/events/registration/notifications.py Outdated Show resolved Hide resolved
indico/modules/events/management/templates/_settings.html Outdated Show resolved Hide resolved
@vasantvohra vasantvohra force-pushed the event_locale branch 7 times, most recently from db071b1 to d2aeec9 Compare January 11, 2023 12:05
@vasantvohra vasantvohra force-pushed the event_locale branch 2 times, most recently from ef65065 to 9145422 Compare January 18, 2023 12:45
@vasantvohra vasantvohra marked this pull request as ready for review January 19, 2023 14:19
@vasantvohra vasantvohra force-pushed the event_locale branch 9 times, most recently from 73b051c to e5b5215 Compare January 21, 2023 10:57
@paulmenzel
Copy link

Nice work, thank you @vasantvohra and @ThiefMaster.

@vasantvohra, if you could extend the merge/pull request description and commit message adding one or two sentences about the feature and the implementation?

Maybe add one or two screenshots to the merge/pull request description?

@paulmenzel
Copy link

@vasantvohra, talking to @ThiefMaster, amend the commit message is not necessary. Only the merge/pull request description could be extended.

@ThiefMaster ThiefMaster added this to the v3.2 milestone Jan 23, 2023
@vasantvohra vasantvohra changed the title Add event language settings Add settings for a default and additional language to an event Jan 23, 2023
@vasantvohra
Copy link
Contributor Author

vasantvohra commented Jan 23, 2023 •
edited
Loading

@vasantvohra, talking to @ThiefMaster, amend the commit message is not necessary. Only the merge/pull request description could be extended.

Hi @paulmenzel, I have updated the description with the screenshots, let me know if any other changes are required 👍

paulmenzel
paulmenzel approved these changes Jan 23, 2023
View reviewed changes
Copy link

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@vasantvohra vasantvohra changed the title Add settings for a default and additional language to an event Add settings for a default and additional languages to an event Jan 23, 2023
@ThiefMaster ThiefMaster enabled auto-merge (squash) February 2, 2023 17:00
@ThiefMaster ThiefMaster enabled auto-merge (squash) February 2, 2023 17:06
@ThiefMaster ThiefMaster merged commit 221d3d5 into indico:master Feb 2, 2023
@vasantvohra vasantvohra deleted the event_locale branch February 3, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmenzel paulmenzel paulmenzel approved these changes

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vasantvohra @paulmenzel @ThiefMaster