Add settings for a default and additional languages to an event#5607
Merged
Conversation
vasantvohra
force-pushed
the
event_locale
branch
from
9d95528 to
d318cd4
Compare
vasantvohra
force-pushed
the
event_locale
branch
from
3e37d90 to
300a73e
Compare
ThiefMaster
reviewed
Jan 8, 2023
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
Please rebase the PR, I just updated the headers so after a rebase these CI warnings will go away
vasantvohra
force-pushed
the
event_locale
branch
7 times, most recently
from
db071b1 to
d2aeec9
Compare
vasantvohra
force-pushed
the
event_locale
branch
from
844a67d to
66a4220
Compare
ThiefMaster
reviewed
Jan 17, 2023
vasantvohra
force-pushed
the
event_locale
branch
2 times, most recently
from
ef65065 to
9145422
Compare
vasantvohra
force-pushed
the
event_locale
branch
from
9145422 to
b4e9efd
Compare
ThiefMaster
reviewed
Jan 19, 2023
ThiefMaster
force-pushed
the
event_locale
branch
from
b4e9efd to
d9ba3ac
Compare
vasantvohra
force-pushed
the
event_locale
branch
9 times, most recently
from
73b051c to
e5b5215
Compare
ThiefMaster
force-pushed
the
event_locale
branch
from
e5b5215 to
8264237
Compare
ThiefMaster
approved these changes
Jan 23, 2023
|
Nice work, thank you @vasantvohra and @ThiefMaster. @vasantvohra, if you could extend the merge/pull request description and commit message adding one or two sentences about the feature and the implementation? Maybe add one or two screenshots to the merge/pull request description? |
|
@vasantvohra, talking to @ThiefMaster, amend the commit message is not necessary. Only the merge/pull request description could be extended. |
ThiefMaster
force-pushed
the
event_locale
branch
from
2358b75 to
3e46d3d
Compare
vasantvohra
changed the title
Contributor
Author
Hi @paulmenzel, I have updated the description with the screenshots, let me know if any other changes are required 👍 |
vasantvohra
changed the title
ThiefMaster
force-pushed
the
event_locale
branch
from
ab57c5e to
3dc1878
Compare
ThiefMaster
force-pushed
the
event_locale
branch
from
3dc1878 to
1983ba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes
Additionally, when sending automated emails to registrants, the language selected will be based on the preferences of the user attached to the registration, if registration is without a user the event default is used.
A unit test is added for the event's language selection behavior.