Expose room location in room booking's UI #5622
Conversation
mindouro
force-pushed
the
expose-location-in-ui
branch
from
f7e2dbb
to
39b0b57
Compare
|
Nice! I wonder if the Location filter should be shown only if there's more than one location, since otherwise it's pretty pointless to filter by it. |
I'm checking how many locations we have before showing the location's filter to avoid that. I also won't show the location in the room's card or details if there is only one location. 🙂 |
indico/modules/rb/client/js/modules/roomList/filters/LocationForm.jsx
Outdated
Show resolved
Hide resolved
mindouro
force-pushed
the
expose-location-in-ui
branch
2 times, most recently
from
39a95e0
to
c8e1890
Compare
| {showLocation && ( | ||
| <div> | ||
| <Icon name="map pin" /> {room.locationName || Translate.string('Not specified')} | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
The room card looks rather broken with the location information added:
There was a problem hiding this comment.
This happens because the class .room-card in Room.module.scss has a fixed height value of 320px. My solution was removing the height of it and let Semantic UI's Card.Group component manage the card's heigh, keeping the same height for all cards of that row and avoiding future problems when adding any other new fields to the room card. Let me know if you prefer other approach 🙂
There was a problem hiding this comment.
I'm not really convinced by the new look TBH. It still looks "wrong".
Maybe we can just ditch showing the location in the room card? It's not very important and if you want to know it you can either filter by it or open the room details...
There was a problem hiding this comment.
(I added a commit to not show the location there)
mindouro
force-pushed
the
expose-location-in-ui
branch
from
c8e1890
to
36c4a98
Compare
mindouro
force-pushed
the
expose-location-in-ui
branch
from
36c4a98
to
1fa223d
Compare
ThiefMaster
force-pushed
the
expose-location-in-ui
branch
from
1fa223d
to
de81135
Compare
It's not THAT important to show it there and it usually results in weird layout (even more so if it's a long location name)
ThiefMaster
force-pushed
the
expose-location-in-ui
branch
from
91008dc
to
5430e3d
Compare
Closes #4291
This PR adds the possibility to filter by location in the Room Booking, when there are more than one location.
This also adds the location value in the room's card and inside the room's details modal.