Fix some API calls with personal tokens #5627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When accessing APIs returning speaker information determining the sort order for speakers accesses `session.user` (as `display_full_name` uses a user preference), but doing so from an API call results in a call to `get_request_user` which does not know about the API and thus does another oauth scope check for the `everything` scopes, which fails if the token used to authenticate the API call doesn't have that scope. The workaround (considering that the API is legacy) is to always return "no user" since legacy API calls are not really considered in the context of a user (except for access checks) anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing APIs returning speaker information determining the sort order for speakers accesses
session.user(asdisplay_full_nameuses a user preference), but doing so from an API call results in a call toget_request_userwhich does not know about the API and thus does another oauth scope check for theeverythingscopes, which fails if the token used to authenticate the API call doesn't have that scope.The workaround (considering that the API is legacy) is to always return "no user" since legacy API calls are not really considered in the context of a user (except for access checks) anyway.