Keep state of undone timeline revisions #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
force-pushed
the
undo-revisions
branch
2 times, most recently
from
b0b92e9
to
587b0f4
Compare
duartegalvao
force-pushed
the
undo-revisions
branch
from
587b0f4
to
81549e1
Compare
duartegalvao
force-pushed
the
undo-revisions
branch
4 times, most recently
from
c08d93d
to
2dc77bf
Compare
duartegalvao
force-pushed
the
undo-revisions
branch
4 times, most recently
from
b7ca60f
to
ee3438f
Compare
ThiefMaster
force-pushed
the
undo-revisions
branch
4 times, most recently
from
5044598
to
3852443
Compare
|
While testing this I ended up with some cases with broken states, some not recoverable from the UI...
|
The memoize_request in valid_revisions was causing the newly created revision to not be listed there, thus publishing the editable failed because the ensure_latest_revision failed.
ThiefMaster
force-pushed
the
undo-revisions
branch
from
efc9326
to
0e6b64e
Compare
duartegalvao
force-pushed
the
undo-revisions
branch
from
0e6b64e
to
21e9c5d
Compare
ThiefMaster
approved these changes
Mar 2, 2023
bpedersen2
pushed a commit
to bpedersen2/indico
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5612
This PR turns the "Undo revision" feature of the Editing Timeline into a "soft" undo, keeping all files and comments available in the timeline:
Progress: