Add setting to prevent disabling profile data sync #5648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Feb 6, 2023
duartegalvao
force-pushed
the
lock-synced-fields
branch
2 times, most recently
from
94e9535 to
3e52923
Compare
ThiefMaster
force-pushed
the
lock-synced-fields
branch
from
3e52923 to
044915a
Compare
ThiefMaster
reviewed
Feb 9, 2023
|
Could we add some tooltip when a field is locked? Maybe even a custom message that can be set in the config ( |
ThiefMaster
force-pushed
the
lock-synced-fields
branch
from
cff6b48 to
3efff25
Compare
ThiefMaster
force-pushed
the
lock-synced-fields
branch
from
3c99ce7 to
89801d4
Compare
ThiefMaster
force-pushed
the
lock-synced-fields
branch
from
89801d4 to
65144ad
Compare
Email sync is weird anyway and we'd have to disable most of the email UI as well there
ThiefMaster
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setting to
indico.confto prevent non-admin users of turning off their profile's personal data synchronization.Fields listed in the
locked_fieldssetting can only be de-synced by an administrator.Α custom
locked_field_messagemay also be set to help guide users: