Allow services to set editable as ready for review #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Feb 10, 2023
duartegalvao
force-pushed
the
editable-state-override
branch
from
37f8c69
to
20d7e3f
Compare
ThiefMaster
reviewed
Feb 13, 2023
duartegalvao
force-pushed
the
editable-state-override
branch
from
20d7e3f
to
67585bd
Compare
ThiefMaster
reviewed
Feb 16, 2023
duartegalvao
force-pushed
the
editable-state-override
branch
from
67585bd
to
e9a3a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows microsservices to respond to the create-editable handler with a
ready_for_reviewflag, which overrides the editable's state from "new" to "ready for review". This makes it possible to have microsservices that don't submit a revision when a new editable is created. Otherwise, the editable would be stuck in a "new" state, making it impossible to make any reviews.This PR also fixes a front-end bug in which the "Judge" button appears when a revision is not yet ready to review.