Fix file upload when modifying registration in a protected event #5719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the event is protected and the user just accesses it via its registration token (e.g. because the user was originally logged in or used an access key to access the event), the file upload endpoint still enforced the access check, causing file uploads to fail. Now we pass the registration token there as well and thus skip the access check when the endpoint is accessed in the context of an existing registration.
ThiefMaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the event is protected and the user just accesses it via its registration token (e.g. because the user was originally logged in or used an access key to access the event), the file upload endpoint still enforced the access check, causing file uploads to fail.
Now we pass the registration token there as well and thus skip the access check when the endpoint is accessed in the context of an existing registration.