Add watchfiles-based reloader #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
watchfiles
branch
3 times, most recently
from
b502818 to
9988ca0
Compare
Watchman works great, but there's no proper release for Python 3.10+ and it requires installing the watchman binary. Watchfiles on the other hand is much easier to install as it includes its (Rust-based) inotify backend in its wheel. The only real drawback is that there's no magic that detects and fully groups Git changes (e.g. checkouts). But debouncing covers this just fine, and if needed the thresholds could be tuned (if some poor soul develops on a super slow machine where Git checkouts take ages).
|
d69b026 fixes an issue during startup when not specifying the reloader but relying on the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchman works great, but there's no proper release for Python 3.10+ and it requires installing the watchman binary.
Watchfiles on the other hand is much easier to install as it includes its (Rust-based) inotify backend in its wheel.
The only real drawback is that there's no magic that detects and fully groups Git changes (e.g. checkouts). But debouncing covers this just fine, and if needed the thresholds could be tuned (if some poor soul develops on a super slow machine where Git checkouts take ages).
I might refactor it a bit to remove the duplicate code between {watchman,watchfiles}.py but I mainly wanted to have a reloader that works well w/ Python 3.11 to make testing Python 3.11 compatibility less painful...