Skip to content

Include start/end times of whole booking in tooltip #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GovernmentPlates
Copy link
Member

@GovernmentPlates GovernmentPlates commented Apr 17, 2023

Closes #5730
Screenshot 2023-04-17 at 14 12 06

@GovernmentPlates GovernmentPlates force-pushed the Reoccuring-Booking-Indicator-5730 branch from 9109349 to 81dbc3c Compare April 17, 2023 12:46
@GovernmentPlates GovernmentPlates marked this pull request as ready for review April 17, 2023 12:46
@GovernmentPlates GovernmentPlates force-pushed the Reoccuring-Booking-Indicator-5730 branch 2 times, most recently from 6ad92b8 to 9a79e38 Compare April 17, 2023 13:34
@GovernmentPlates GovernmentPlates force-pushed the Reoccuring-Booking-Indicator-5730 branch 2 times, most recently from e09336e to 833b836 Compare April 17, 2023 14:58
@tomasr8
Copy link
Member

tomasr8 commented Apr 18, 2023

All looks good, just the string interpolation 😄 Ideally, we'd have 3 separate messages depending on the recurrence frequency

@GovernmentPlates GovernmentPlates force-pushed the Reoccuring-Booking-Indicator-5730 branch 2 times, most recently from d9fc0d4 to b2c19cf Compare April 21, 2023 14:05
@ThiefMaster ThiefMaster force-pushed the Reoccuring-Booking-Indicator-5730 branch from b2c19cf to e641e29 Compare April 25, 2023 16:15
@ThiefMaster ThiefMaster enabled auto-merge (squash) April 25, 2023 16:28
@ThiefMaster ThiefMaster merged commit 4e7d0c9 into indico:master Apr 25, 2023
@GovernmentPlates GovernmentPlates deleted the Reoccuring-Booking-Indicator-5730 branch July 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include start/end of whole booking in tooltip
3 participants