Skip to content

Add setting to force track selection on judgment #5771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2023

Conversation

duartegalvao
Copy link
Member

This PR adds a setting to force track selection when accepting abstracts:

Screen Shot 2023-05-12 at 13 21 34 image

@duartegalvao duartegalvao force-pushed the force-track-selection branch from 23ab359 to eede26e Compare May 12, 2023 12:51
@ThiefMaster
Copy link
Member

Is bulk judgment exempt from this on purpose?

@ThiefMaster ThiefMaster force-pushed the force-track-selection branch from eede26e to 28de506 Compare May 12, 2023 16:15
@duartegalvao
Copy link
Member Author

Is bulk judgment exempt from this on purpose?

Since it's a manager-only action I don't think there's a need for it, since this feature is mostly to tackle cases where there are multiple review tracks and the judge accepts without selecting the track (since in most cases, it's already preselected)

I could implement it there to make it more consistent though.. Or maybe rephrase the setting to something like "Force judges to select tracks"?

@ThiefMaster
Copy link
Member

Being more explicit sounds good. The question is whether managers doing a judgment should also be required to choose a track or not though... currently they are and I think it's fine, because in an event where you enforce it, you probably always want at rack selected, but then a wording mentioning judges explicitly won't fit anymore.

Or we could just mention "Does not affect bulk judgment by managers" in the description of the setting and leave the logic as it is right now... ;)

@duartegalvao duartegalvao force-pushed the force-track-selection branch from 28de506 to db0431e Compare May 16, 2023 07:39
@duartegalvao duartegalvao requested a review from ThiefMaster May 16, 2023 07:40
@ThiefMaster ThiefMaster merged commit e99d97e into indico:master May 16, 2023
@ThiefMaster ThiefMaster deleted the force-track-selection branch May 16, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

2 participants