Add option to clone Badge template into a different category #5775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 15, 2023
SegiNyn
force-pushed
the
badge-template-clone
branch
4 times, most recently
from
fa593ef to
1ad3421
Compare
|
Hello @ThiefMaster, please this is ready for another review. Thank you. |
SegiNyn
force-pushed
the
badge-template-clone
branch
from
1ad3421 to
a380258
Compare
SegiNyn
force-pushed
the
badge-template-clone
branch
from
a380258 to
f578683
Compare
|
Hello @ThiefMaster, please any updates on this pr? Is there something else to do on my side? |
|
I'm getting the "The selected category does not contain any events, only subcategories. Please make sure that you really want to create an event there." warning - this should not happen since we're not creating events... |
|
OK that's a simple fix, |
ThiefMaster
force-pushed
the
badge-template-clone
branch
from
f578683 to
6d7504f
Compare
Make it opt-in and clarify it's about warnings related to event creation
You can't put everything in the Markup() call, since the badge title is not trustworthy and thus should be handled as potentially insecure HTML.
ThiefMaster
approved these changes
Jul 18, 2023
|
Thank you @ThiefMaster for the improvements added 🙏 |
SegiNyn
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 24, 2023
SegiNyn
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 25, 2023
SegiNyn
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add an option to clone Badge Templates from a category into a different category