Show an actual recipient on the emails' preview #5794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 31, 2023
duartegalvao
force-pushed
the
email-previews
branch
from
4291e49 to
c587baa
Compare
ThiefMaster
force-pushed
the
email-previews
branch
2 times, most recently
from
5adb7f2 to
cb2db18
Compare
ThiefMaster
force-pushed
the
email-previews
branch
from
cb2db18 to
e7ea503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the email dialogs' preview screen use an actual recipient's data on the placeholders instead of the event's creator.
Note: roles of recipients are not taken into account on the
EmailContribAbstractRolesdue to the added complexity on the client-side (can implement if deemed necessary)