Display confirmation prompt body as text instead of HTML #5862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update some confirmation prompts to not use HTML in the message as this is no longer supported.
ThiefMaster
added a commit
that referenced
this pull request
Dec 21, 2023
The prompt no longer supports HTML since #5862
VojtechPetru
pushed a commit
to VojtechPetru/indico
that referenced
this pull request
Jan 12, 2024
The prompt no longer supports HTML since indico#5862
micsucmed
pushed a commit
to micsucmed/indico
that referenced
this pull request
Jan 19, 2024
The prompt no longer supports HTML since indico#5862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an XSS issue in places where the confirmation prompt contains e.g. the name of the object being deleted.
The few places where we used formatting in those bodies, now use plain text as HTML in the message is no longer supported.