Skip to content

Material package: Files linked to sessions are skipped #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ThiefMaster
Copy link
Member

This is most likely because _get_start_dt in indico/modules/attachments/controllers/event_package.py returns None for a session (sessions do not really have a start date). However, we could use their start_dt nonetheless, because that uses the start date of its first block which would probably do the job well enough.

@ThiefMaster ThiefMaster added the bug label Nov 7, 2023
@ThiefMaster ThiefMaster changed the base branch from master to 3.2.x November 7, 2023 15:29
@ThiefMaster ThiefMaster added the build-wheel Build a Python wheel for this PR label Nov 7, 2023
@ThiefMaster ThiefMaster added this to the v3.2 milestone Nov 7, 2023
@ThiefMaster ThiefMaster merged commit cbba25f into indico:3.2.x Nov 7, 2023
@ThiefMaster ThiefMaster deleted the mat-pkg-sessions branch November 7, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build-wheel Build a Python wheel for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant