Include comment in editing notification emails #6042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
suggested changes
Nov 17, 2023
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
|
Code uses en_US, so "program code" (and user-facing parts get en_GB via a translation on transifex, so anything in the repo can be en_US) |
ThiefMaster
reviewed
Nov 20, 2023
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
from
101ba09 to
983e99d
Compare
duartegalvao
approved these changes
Nov 22, 2023
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
2 times, most recently
from
da1fc72 to
530bacd
Compare
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
2 times, most recently
from
155947b to
5870a7a
Compare
ThiefMaster
reviewed
Nov 30, 2023
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/comment_notification.txt
Outdated
Show resolved
Hide resolved
|
@duartegalvao do we need the same for notifications related to editor reviews? |
I was actually thinking about this yesterday... Nobody complained but I think it would be also nice to have. So @micsucmed if you don't mind you can go ahead with this, you'll be a superstar 😄 (PS although this PR is crucial there is no rush - the next conference this is needed for is IPAC24 which is only in may) |
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
from
e5ace92 to
b3d2c18
Compare
Should I add the changes for the other notifications to this PR or do another one? |
|
IMHO they can go in here since the two things are so closely related |
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
2 times, most recently
from
4f05d8f to
835cee4
Compare
duartegalvao
suggested changes
Dec 5, 2023
indico/modules/events/editing/templates/emails/editor_judgment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/editor_judgment_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/submitter_confirmation_notification.txt
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/templates/emails/submitter_rejection_notification.txt
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
from
f29afcf to
bf507b8
Compare
micsucmed
force-pushed
the
timeline-message-notifications-editors-authors
branch
from
bf507b8 to
98cba17
Compare
ThiefMaster
reviewed
Dec 21, 2023
Include contribution ID and programme_code in subject
Include contribution verbose title on comment notifications
ThiefMaster
force-pushed
the
timeline-message-notifications-editors-authors
branch
from
98cba17 to
a6df6e4
Compare
ThiefMaster
force-pushed
the
timeline-message-notifications-editors-authors
branch
from
da47749 to
2b1087c
Compare
Very long lines don't look great in plaintext emails, and contribution titles can already be long. So it's better to avoid interpolating those long titles into sentences.
That way the string only needs to be translated once
VojtechPetru
pushed a commit
to VojtechPetru/indico
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
micsucmed
added a commit
to micsucmed/indico
that referenced
this pull request
Jan 19, 2024
Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include contribution ID and programme_code in subject
closes #6027