Skip to content

Add en_CA locale #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Add en_CA locale #6063

merged 1 commit into from
Dec 11, 2023

Conversation

OmeGak
Copy link
Member

@OmeGak OmeGak commented Nov 25, 2023

No description provided.

@ThiefMaster
Copy link
Member

I think even if there are no different words (dunno if they have weird (mis)spellings like the Brits do ;)), it should be done via Transifex (cc @tomasr8) for the sake of consistency.

Also, you need to include the locale for momentjs. See this page in the docs or one of the PRs where we added a new language.

@tomasr8
Copy link
Member

tomasr8 commented Nov 27, 2023

I added en_CA on transifex, you can pull the (empty) po files with indico i18n pull indico en_CA

@ThiefMaster
Copy link
Member

@OmeGak will you add the fixes related to missing locale-specific formatting to this PR or a separate one? Probably it doesn't make that much sense to merge this without the other fixes since the main point of adding en_CA is to get proper l10n

@OmeGak OmeGak force-pushed the wip/en-ca branch 2 times, most recently from a10a109 to f576c43 Compare December 9, 2023 12:16
@OmeGak OmeGak marked this pull request as ready for review December 9, 2023 12:33
@OmeGak
Copy link
Member Author

OmeGak commented Dec 9, 2023

This PR should be ready to merge. My last f-push:

  • Added all the .po files as pulled from Transifex.
  • Added the en-ca locale to indico/web/client/js/jquery/index.js.
  • Changed the author of this commit to Indico Team <indico-team@cern.ch>.

Also, @ThiefMaster, the date picker widget respects the en_CA locale once installed properly. I didn't find any other place in Indico where the short format is used.

@ThiefMaster ThiefMaster added this to the v3.3 milestone Dec 9, 2023
@ThiefMaster ThiefMaster merged commit 25b15ba into indico:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants