Skip to content

Calendar: filter by room #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 14, 2024
Merged

Conversation

Moliholy
Copy link
Contributor

@Moliholy Moliholy commented Jan 30, 2024

Closes #6148
Closes #6149

This PR adds the following:

  • Two actions to the calendar legend: one for selecting all items and another one for deselecting them all.
  • Filtering by room in the legend.

Screenshots

Screenshot 2024-01-31 at 18 04 15 Screenshot 2024-01-31 at 18 01 36

@Moliholy Moliholy changed the title Add buttons to (de)select all items in legend Calendar: filter by room Jan 30, 2024
@Moliholy Moliholy force-pushed the calendar-filtering branch 5 times, most recently from 31d1309 to 16a0784 Compare February 1, 2024 11:48
@Moliholy Moliholy force-pushed the calendar-filtering branch 2 times, most recently from efe7ccd to 473b13e Compare February 1, 2024 15:37
@Moliholy
Copy link
Contributor Author

Moliholy commented Feb 1, 2024

@ThiefMaster ready for review 😎

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have not really looked at the logic yet, this is just the one thing that i immediately noticed which could be shortened a bit

@Moliholy
Copy link
Contributor Author

Moliholy commented Feb 6, 2024

Rebased to the lastest master branch.

@ThiefMaster
Copy link
Member

What do you think about using natural sort order for this list?

image

const collator = new Intl.Collator(undefined, {numeric: true, sensitivity: 'base'});
whatever.sort((a, b) => collator.compare(a, b));

@ThiefMaster
Copy link
Member

ThiefMaster commented Feb 7, 2024

I'd add the two issues and this PR to the relevant changelog entries added in the last PR, and adjust the wording there if needed

@Moliholy
Copy link
Contributor Author

Moliholy commented Feb 9, 2024

What do you think about using natural sort order for this list?

Agreed. Just applied the changes.

@Moliholy
Copy link
Contributor Author

Moliholy commented Feb 9, 2024

I'd add the two issues and this PR to the relevant changelog entries added in the last PR, and adjust the wording there if needed

Done in f3424a5.

@ThiefMaster
Copy link
Member

image

  • It looks rather weird when there are events with just a venue but no room
  • The little triangle generally collapses/expands something, so I was rather surprised when this wasn't the case here.
  • The room list in there is not using natural sorting order

@Moliholy
Copy link
Contributor Author

It looks rather weird when there are events with just a venue but no room
The room list in there is not using natural sorting order

Both of them fixed.

The little triangle generally collapses/expands something, so I was rather surprised when this wasn't the case here.

The triangle was used initially just to visually align different elements. Ideally in a second iteration we planned to allow collapsing elements.

@Moliholy Moliholy force-pushed the calendar-filtering branch 3 times, most recently from 84a65b7 to 9cae7ae Compare February 14, 2024 00:30
@ThiefMaster ThiefMaster merged commit 82ac76f into indico:master Feb 14, 2024
@ThiefMaster ThiefMaster added this to the v3.3 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to display events in category calendar per room Add controls to select/clear all items in the category calendar legend
2 participants