New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Lines on Graph Functionality #24

Merged
merged 6 commits into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@mrfambo
Copy link
Contributor

mrfambo commented Jul 7, 2018

Hey,

I have created the multiple lines graph functionality. I hope its something valuable because after surfing a lot on web i found nothing interesting.

"_main": "./node_modules/react-native-scripts/build/bin/crna-entry.js",
"main": "./index.js",
"main": "./node_modules/react-native-scripts/build/bin/crna-entry.js",
"_main": "./index.js",

This comment has been minimized.

@Hermanya

Hermanya Jul 7, 2018

Contributor

.DS_Store and package-lock.json need to be removed. We already have yarn.lock

The package.json change needs to be removed. I know that it sucks, the example should really be in a subfolder, so that we don't have this problem.

@@ -159,17 +212,21 @@ class LineChart extends AbstractChart {
...config,
paddingRight,
paddingTop,
data: data.datasets[0].data
// data: data.datasets[0].data

This comment has been minimized.

@Hermanya

Hermanya Jul 7, 2018

Contributor

And please remove this commented code.

@Hermanya

This comment has been minimized.

Copy link
Contributor

Hermanya commented Jul 7, 2018

I run your clone. The graph looks somewhat confusing. Could you share a screenshot of how you are using this graph? How do you show which line represents what?

@Hermanya Hermanya merged commit 465572f into indiespirit:master Jul 12, 2018

@Hermanya

This comment has been minimized.

Copy link
Contributor

Hermanya commented Jul 12, 2018

Fixed all the minor things. @alimuqaddas congrats on your first Open Source Contribution 👍 thank you very much 😄
I'm still curious how you are using this graph in your app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment