Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify step 7 "has 1+ h-card" #2

Open
aaronpk opened this issue Feb 15, 2020 · 0 comments
Open

Clarify step 7 "has 1+ h-card" #2

aaronpk opened this issue Feb 15, 2020 · 0 comments

Comments

@aaronpk
Copy link
Member

aaronpk commented Feb 15, 2020

(originally posted 2017-02-24 on the wiki)

In step 7, "if author-page has 1+ h-card...", can you clarify the meaning of "has"? In my implementation, I was checking for the presence of this h-card by iterating through all top-level "items" on the page and checking those. However, I believe I found an example where this fails. When the home page h-card is actually the "author" property of the top-level h-feed, my consuming code doesn't find this h-card. Is this sentence intended to match this case? If so, clarification on what it means to say a page "has" an h-card would be helpful. Parsing the HTML for h-card will easily find this h-card, but once you're working with the mf2 parsed result, it is buried a little deeper in the data structure.
@gRegorLove gRegorLove mentioned this issue Mar 18, 2020
Closed
aaronpk added a commit to aaronpk/XRay that referenced this issue Apr 21, 2020
@aaronpk
fix for missing author property
d2b0109 
* looks through the full mf2 tree for step 7 of authorship indieweb/authorship#2
* if no author h-card is found, falls back to returning the author URL without other data instead of missing author

closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronpk