Skip to content

Fix templates for Rails 4 #32

Merged
merged 1 commit into from Dec 30, 2012

3 participants

@deeeki
deeeki commented Nov 20, 2012

Remove "key_value" helper from index template.

Following is occurred error in scaffolding at current version.

(erb):19:in `template': undefined method `key_value' for #<Haml::Generators::ScaffoldGenerator:0x007fb9712be1e8> (NoMethodError)

Please edit gemspec for Rails4 like "~> 4.0.0.beta" coz it's used the 1.9 hash syntax.

@itzki itzki Fix templates for Rails 4
Remove "key_value" helper
e3b6b25
@indirect
Owner

Why not keep 1.8 compatibility?

@deeeki
deeeki commented Nov 21, 2012

I followed Rails core's style. rails/rails@1ced5ca
How about creating branch for Rails3(Ruby1.8)?

@indirect
Owner

I'd rather keep a single gem that's broadly compatible.

@indirect
Owner

If you'd like to generate 1.9-style on 1.9, please go ahead and do that... just add some code so that it generates a working template on 1.8, too. Thanks!

@deeeki
deeeki commented Nov 21, 2012

I see. It's surely good to keep a single gem with compatibility. Thanks :)

@indirect indirect merged commit e3b6b25 into indirect:master Dec 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.