New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project and fix errors #44

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@boyvanamstel
Copy link
Contributor

boyvanamstel commented Jan 19, 2019

Fixes all warnings and errors in both the frameworks and the example apps, restoring them to working condition.

I updated the deployment targets as there were already methods used that are not available in iOS 8.1 and macOS 10.10:

screenshot 2019-01-19 at 23 18 53

@boyvanamstel

This comment has been minimized.

Copy link
Contributor Author

boyvanamstel commented Jan 22, 2019

Would love to get this merged. Let me know if there's anything I can do to help make that happen. ☺️

@indragiek
Copy link
Owner

indragiek left a comment

Thanks for doing this! Just one thing I want some clarification on :)

@@ -106,6 +106,6 @@ private extension Array {
indices.append(random)
}

return indices.map { self[$0] }
return indices.map { self[$0 - 1] }

This comment has been minimized.

@indragiek

indragiek Jan 22, 2019

Owner

Could you comment on this change? This seems like a behavioral change rather than a compiler error fix.

This comment has been minimized.

@boyvanamstel

boyvanamstel Jan 22, 2019

Author Contributor

I noticed that randomValues(_:seed:) crashed with an index out of bounds and 'fixed' the issue by bringing it back into bounds. Upon further investigation it seems the method only crashes for some images.

The crashes are consistent, but honestly I'm not familiar enough with the code that I can fix it straight away. Thus I've removed the change and left it as is.

@indragiek

This comment has been minimized.

Copy link
Owner

indragiek commented Jan 22, 2019

Thanks again!

@indragiek indragiek merged commit 5d4bffd into indragiek:master Jan 22, 2019

@indragiek indragiek referenced this pull request Jan 22, 2019

Merged

Fix IBAction interface #38

@boyvanamstel

This comment has been minimized.

Copy link
Contributor Author

boyvanamstel commented Jan 22, 2019

You’re welcome. :)

@boyvanamstel boyvanamstel deleted the boyvanamstel:update branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment