Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor functionality from the GrounderInstance class into the Grounder class #16

Merged
merged 5 commits into from Mar 17, 2020

Conversation

@cthoyt
Copy link
Contributor

cthoyt commented Mar 17, 2020

The only functionality I can see for the GrounderInstance class is to make the instance of the grounder lazy. Therefore, I moved some of the functionality from this class directly into the Grounder class, which should make it more reusable.

@cthoyt cthoyt changed the title Refactor functionality from GrounderInstance class to Grounder class Refactor functionality from the GrounderInstance class into the Grounder class Mar 17, 2020
gilda/api.py Outdated Show resolved Hide resolved
gilda/grounder.py Outdated Show resolved Hide resolved
gilda/grounder.py Show resolved Hide resolved
@bgyori bgyori force-pushed the cthoyt:improve-api-reusability-2 branch from a683108 to f41c742 Mar 17, 2020
cthoyt added 3 commits Mar 17, 2020
The only functionality I can see for the GrounderInstance is to make the instance of the grounder lazy. Therefore, I moved some of the functionality from this class directly into the Grounder class
@bgyori bgyori force-pushed the cthoyt:improve-api-reusability-2 branch from f41c742 to 3aab21e Mar 17, 2020
@bgyori bgyori force-pushed the cthoyt:improve-api-reusability-2 branch from 677620f to 12fc541 Mar 17, 2020
@bgyori bgyori merged commit 6040f4f into indralab:master Mar 17, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cthoyt cthoyt deleted the cthoyt:improve-api-reusability-2 branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.