Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Make stack frame keys (u/d) match order in stack frame list #4

Closed
wants to merge 1 commit into from

2 participants

@asmeurer
Collaborator

You don't have to accept this, but it seemed to me that the keys for the stack frame were backward, given that the top most level of the stack is at the top of the stack list.

Maybe a better fix would be to make it bottom to top in the list again.

@inducer
Owner

I realize that something there is backwards. But intuitively i do prefer the bottompmost stack frame at the top of the list. (Just because you're more likely to want to navigate to it, or things near it.) Yet, there's established terminology in terms of what 'up' and 'down' mean on a stack... If you insist, you could make this an option, and I'd likely accept that.

@inducer inducer closed this
@asmeurer
Collaborator

OK, I'll submit a patch making it an option to have the stack top-down or bottom-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +4 −4 pudb/debugger.py
View
8 pudb/debugger.py
@@ -22,8 +22,8 @@
t - run to cursor
e - show traceback [post-mortem or in exception state]
- u - move up one stack frame
- d - move down one stack frame
+ u - move down one stack frame
+ d - move up one stack frame
! - invoke python shell in current environment
o - show console/output screen
@@ -474,8 +474,8 @@ def move_stack_up(w, size, key):
def move_stack_down(w, size, key):
self.debugger.move_down_frame()
- self.stack_list.listen("u", move_stack_up)
- self.stack_list.listen("d", move_stack_down)
+ self.stack_list.listen("d", move_stack_up)
+ self.stack_list.listen("u", move_stack_down)
self.source_sigwrap.listen("u", move_stack_up)
self.source_sigwrap.listen("d", move_stack_down)
Something went wrong with that request. Please try again.