Add an option to change the order of the stack #6

Merged
merged 2 commits into from Jul 28, 2011

Projects

None yet

2 participants

@asmeurer
Collaborator

The keyboard shortcuts u/d seem backwards with the current order. On
the other hand, it seems like the current stack frame should be on top
to some. Therefore, we make this an option. See
#4.

This will need to be updated when pull #5 is in (or visa versa).

@asmeurer asmeurer Add an option to change the order of the stack
The keyboard shortcuts u/d seem backwards with the current order.  On
the other hand, it seems like the current stack frame should be on top
to some.  Therefore, we make this an option.  See
inducer#4.
fabad16
Owner
inducer commented Jul 28, 2011

This needs one more tweak, I believe: There's another spot in the code that processes "Enter" presses on stack frames that needs to know about this reversal.

https://github.com/inducer/pudb/blob/master/pudb/debugger.py#L466

Collaborator

OK, I'll look into it. I based the change off of 6a3b676, but I didn't consider that future changes would take the new order into account.

Collaborator

OK, I fixed it.

@inducer inducer merged commit 56173c5 into inducer:master Jul 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment