Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 #892

Merged
merged 65 commits into from Sep 29, 2022
Merged

Bootstrap 5 #892

merged 65 commits into from Sep 29, 2022

Conversation

inducer
Copy link
Owner

@inducer inducer commented Feb 22, 2022

This is starting to look like something.

  • Fix tests
  • Starter code fold doesn't work
  • Adapt sample course content: Update for Bootstrap 5 relate-sample#15
  • InlineMultiQuestion forms are broken
  • InlineMultiQuestions have a JS error
  • Flow pages still refer to $(...).resizable()
  • Correct/incorrect markings on InlineMultiQuestion are broken.

Known issues (won't prevent merge):

Closes: #616

{% endif %}
{% if pperm.view_gradebook %}
<li>
<a class="dropdown-item" href="{% url 'relate-grade_flow_page' course.identifier flow_session.id page_ordinal %}"

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
{% endif %}
{% if page_expect_answer_and_gradable and pperm.grant_exception and flow_session.participation.id != None %}
<li>
<a class="dropdown-item" href="{% url 'relate-grant_exception_stage_3' course.identifier flow_session.participation.id flow_session.flow_id flow_session.id %}"

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
<li role="separator" class="divider"></li>
{% if pperm.reopen_flow_session and not flow_session.in_progress and opportunity.id != None %}
<li>
<a href="{% url 'relate-view_reopen_session' course.identifier flow_session.id opportunity.id %}"

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.

{% if may_send_email_about_flow_page %}
<div class="relate-flow-page-send-email">
<a href="{% url 'relate-flow_page_interaction_email' course.identifier flow_session.id page_ordinal %}"

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
{% block navbar_dropdown_staff_menu_admin %}
{% if user.is_staff %}
<li><a href="{% url 'admin:index' %}" target="_blank">{% trans "Admin site" %}</a></li>
<li><a class="dropdown-item" href="{% url 'admin:index' %}" target="_blank">{% trans "Admin site" %}</a></li>

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
<a href="{{ data_url }}" id="file_upload_download_link">{% trans "Review uploaded file" %}</a>
&middot;
<a href="javascript:file_upload_embed_viewer()">{% trans "Embed viewer" %}</a>
<a href="{{ data_url }}" id="file_upload_download_link" target="_blank">{% trans "Download/review uploaded file in new window" %}</a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@inducer inducer marked this pull request as ready for review September 29, 2022 02:01
@inducer inducer enabled auto-merge (rebase) September 29, 2022 02:02
@inducer inducer merged commit 14c8cbf into main Sep 29, 2022
17 checks passed
@inducer inducer deleted the bs5 branch September 29, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to Bootstrap 4?
2 participants