Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WMFLocationManager to Swift #3

Open
wants to merge 19 commits into
base: develop
from
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Add WMFLocationManager testing category

This exposes the initializer allowing dependency injection to the unit test target.
  • Loading branch information
jantimar authored and VojtaStavik committed Feb 28, 2020
commit 978c6c2240e87c512e446c14c32b746e823ca806
83F26B29220B62EC002D87A4 /* SectionEditorButton.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SectionEditorButton.swift; sourceTree = "<group>"; };
83FBE96E1F6172ED0026C7EB /* ShareAFactActivityTextItemProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ShareAFactActivityTextItemProvider.swift; sourceTree = "<group>"; };
83FBE9741F6181E00026C7EB /* ShareAFactActivityImageItemProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ShareAFactActivityImageItemProvider.swift; sourceTree = "<group>"; };
A40BDDA9240519D400D1CA3D /* WMFLocationManager+Testing.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "WMFLocationManager+Testing.h"; sourceTree = "<group>"; };
B00050131C52D73800515F70 /* UIApplication+RTL.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "UIApplication+RTL.swift"; sourceTree = "<group>"; };
B0016CB821354D9D00FA1096 /* AutoLayoutSafeMultiLineButton.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AutoLayoutSafeMultiLineButton.swift; sourceTree = "<group>"; };
B0016CBE2136105900FA1096 /* SetupButton.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SetupButton.swift; sourceTree = "<group>"; };
BC62AE611C58FC810064C589 /* NSProcessInfo+WMFTestEnvironment.m */,
BCD320081C6EC6BC00317D08 /* NSTimeZone+WMFTestingUtils.h */,
BCD320091C6EC6BC00317D08 /* NSTimeZone+WMFTestingUtils.m */,
A40BDDA9240519D400D1CA3D /* WMFLocationManager+Testing.h */,
);
name = Utilities;
sourceTree = "<group>";
@@ -11,3 +11,4 @@
#import "NSURL+WMFLinkParsing.h"
#import "WMFLegacySerializer.h"
#import "Wikipedia-Bridging-Header.h" //https://bugs.swift.org/browse/SR-3801?focusedCommentId=21317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-21317
#import "WMFLocationManager+Testing.h"
@@ -0,0 +1,12 @@
#import <WMF/WMF.h>
#import <WMF/WMFLocationManager.h>

NS_ASSUME_NONNULL_BEGIN

@interface WMFLocationManager (Testing)

- (instancetype)initWithLocationManager:(CLLocationManager *)locationManager device:(UIDevice *)device;

@end

NS_ASSUME_NONNULL_END
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.