Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WMFLocationManager to Swift #3

wants to merge 19 commits into
base: develop
Changes from 1 commit
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

Remove unused method `restartLocationMonitoring`

  • Loading branch information
jantimar authored and VojtaStavik committed Feb 28, 2020
commit a4bc0f7d87ef91ce2bce56fd47eae432096c5894
@@ -30,10 +30,8 @@ NS_ASSUME_NONNULL_BEGIN
- (instancetype)init NS_UNAVAILABLE;

* Start monitoring location and heading updates.
* Start monitoring location and heading updates. This method is idempotent.
* @note
* This method is idempotent. To force new values to be sent, use @c restartLocationMonitoring.
- (void)startMonitoringLocation;

@@ -42,11 +40,6 @@ NS_ASSUME_NONNULL_BEGIN
- (void)stopMonitoringLocation;

* Restart location monitoring, forcing the receiver to emit new location and heading values (if possible).
- (void)restartLocationMonitoring;

+ (BOOL)isAuthorized;

+ (BOOL)isAuthorizationNotDetermined;
@@ -127,11 +127,6 @@ - (BOOL)requestAuthorizationIfNeeded {

#pragma mark - Location Monitoring

- (void)restartLocationMonitoring {
[self stopMonitoringLocation];
[self startMonitoringLocation];

- (void)startMonitoringLocation {
self.requestingAuthorizationAndStart = YES;
if ([self requestAuthorizationIfNeeded] || [WMFLocationManager isAuthorizationDenied] || [WMFLocationManager isAuthorizationRestricted] || self.isUpdating) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.